Skip to content

Update proc to 0.9.0 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 28, 2025
Merged

Update proc to 0.9.0 #68

merged 11 commits into from
May 28, 2025

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Dec 2, 2024

No description provided.

@Mpdreamz Mpdreamz changed the title Update proc to 9.0 Update proc to 0.9.0 Dec 3, 2024
stevejgordon
stevejgordon approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but otherwise it looks good. The title of the PR is 0.9.0, but this uses 0.9.1.

src/Elastic.Elasticsearch.Ephemeral/EphemeralFileSystem.cs
version.Artifact(Product.Elasticsearch).LocalFolderName, clusterName);
var artifact = version.Artifact(Product.Elasticsearch);
var localFolder = artifact.LocalFolderName;
var temp = Path.Combine(Path.GetTempPath(), SubFolder, localFolder, clusterName);
return Path.Combine(temp, "home");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to improved readability here!

@brendon1982
Copy link
Contributor

brendon1982 commented Apr 9, 2025 •
edited
Loading

Hi All,

I've recently brought this branch into our code base, to get this fix nullean/proc#19, and experienced a failure when starting a cluster with the XPack feature on.

It turned out to be an issue with how the parameters are being supplied to ExecuteBinary in EnsureSecurityUsersInDefaultRealmAreAdded to invoke the useradd cli command. They are being supplied as a single string instead of separate strings, as is being done elsewhere when using ExecuteBinary.

To get it working I updated the parameters from:

elasticsearch-net-abstractions/src/Elastic.Elasticsearch.Ephemeral/Tasks/BeforeStartNodeTasks/XPack/EnsureSecurityUsersInDefaultRealmAreAdded.cs

Line 53 in 4bdace0

$"adding user {cred.Username}", $"useradd {cred.Username} -p {cred.Password} -r {cred.Role}");

To:

ExecuteBinary(cluster.ClusterConfiguration, cluster.Writer, pluginBat,
	$"adding user {cred.Username}", "useradd", cred.Username, "-p", cred.Password, "-r", cred.Role);

And it solved it issue.

@Mpdreamz Mpdreamz mentioned this pull request May 28, 2025
Closed
@Mpdreamz
Copy link
Member Author

Great catch @brendon1982 I've included that in this PR now!

@Mpdreamz Mpdreamz merged commit 1002fa8 into master May 28, 2025
5 checks passed
@Mpdreamz Mpdreamz deleted the feature/bump-proc branch May 28, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevejgordon stevejgordon stevejgordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mpdreamz @brendon1982 @stevejgordon